Closed garethbowen closed 6 years ago
AT: Make sure the patches are still being applied to the bundled code.
Hey @garethbowen need some assistance on AT for this one.
Can you share some detail how to AT this one? // patch font-awesome to remove version attributes so appcache works // https://github.com/FortAwesome/Font-Awesome/issues/3286 'patch webapp/node_modules/font-awesome/less/path.less < webapp/patches/font-awesome-remove-version-attribute.patch',
I'm assuming we would need to login as a user with Hindi as the language to see numerals. Where would we expect to see them in the app? // patch moment.js to use western arabic (european) numerals in Hindi 'patch webapp/node_modules/moment/locale/hi.js < webapp/patches/moment-hindi-use-euro-numerals.patch',
These work on my local machine. Once beta.dev comes back up I'll confirm there as well.
Confirmed in beta.dev the patches are still working.
They only apply to webapp so it makes sense to move them down.