medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
439 stars 210 forks source link

Enable default config transitions in e2e tests #6026

Open dianabarsan opened 5 years ago

dianabarsan commented 5 years ago

Describe the issue The default config was updated to enable two transitions: generate_patient_id_on_people and death_reporting. We also recently started using the default config when running our e2e tests suite. Having any enabled transitions (especially generate_patient_id_on_people which updates every contact doc uploaded) can cause our e2e tests to fail in unexpected ways. To release 3.7, the quick solution is to remove transitions from the config before uploading when running e2e tests.

Describe the improvement you'd like We should update the existent tests setup or assertions so they execute successfully using the default config.

garethbowen commented 4 years ago

Pushing back to 3.9.0 as there's no urgency on this one.

garethbowen commented 4 years ago

Moved to 3.12.0 to free up engineers to work on 3.11.0.

ngaruko commented 1 year ago

This ticket hasn't had any attention for close to 3 years. Do you think it is still valid @dianabarsan ?

dianabarsan commented 1 year ago

Yes, we still disable transitions when running e2e tests: https://github.com/medic/cht-core/blob/master/tests/utils.js#L637