medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
441 stars 211 forks source link

Enketo Time Picker does not work on Desktop #7328

Open jkuester opened 3 years ago

jkuester commented 3 years ago

Describe the bug

The Enketo timepicker-extended widget should activate a time selection pop-over (similar to the year/month/date pop-overs) when activated, but it does not. Instead, when running in a normal desktop (not Android) browser, nothing pops up, but the time can be entered into the text box via the keyboard (and no errors are logged to the console).

To Reproduce Steps to reproduce the behavior:

  1. Open a form that contains a time widget:
type name label
time time_select Time widget
  1. Click on the "Time widget" box
  2. Nothing happens...

image

Expected behavior

The Time Picker in the Enketo Widgets Demo activates a time selection pop-over when selected.

image

Environment

Additional context

When running on Android, the expected Android-native time picker is properly activated when a time question is selected.

Also, for the record the in-progress Enketo uplift for #6345 does not seem to fix this issue since the behavior is reproducible even with the new version of Enekto.

I have not been able to determine a cause for this issue, but I do wonder if perhaps it is related to the bootstrap hacking that we do....

jkuester commented 3 years ago

Also worth noting that the same behavior exists for the Date-Time picker too. For that widget, the pop-over for picker the date functions as expected, but there is no pop-over for the time selection.