search

medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
468 stars 217 forks source link

Convert app management add/edit user modal to a page #8189

Open garethbowen opened 1 year ago

garethbowen commented 1 year ago

What feature do you want to improve? If you go to App Management > Users > Add (or click on a row to Edit) a modal dialog is shown. Modals aren't good for forms because it restricts usability, eg: you can't hit back, you can't refresh, you can't open in a new tab, screen real estate is restricted unnecessarily, scrolling doesn't behave quite right, etc.

Describe the improvement you'd like Convert the modal into a page with a unique URL.

Describe alternatives you've considered

Additional context

Screenshot from 2023-04-19 13-52-00

isis-meng commented 1 year ago

Thanks for raising this issue! I'll pick it up and open a branch tomorrow with what I have so far.

isis-meng commented 1 year ago

Hi, I attempted to push some changes to a new branch but I don't appear to have access. Is there something I should do to correct my setup? Thanks!

image

garethbowen commented 1 year ago

@isis-meng I suggest you make a git fork of the cht-core repo into your own user, then you'll be able to create your own branches. Then when it's ready you can PR from your fork to the medic fork.

isis-meng commented 1 year ago

Thanks! I've opened a PR but it's still a work-in-progress -- I've left a comment with some questions I have.

AbeebProPlus commented 1 year ago

Hi. I would love resolve this issue if it has not been resolved

garethbowen commented 1 year ago

Hi @AbeebProPlus ! Thanks for reaching out. @isis-meng has already started working in the above PR - how are you getting on with this issue?

AbeebProPlus commented 1 year ago

It's just a dent on the UI. I hope it's fixed soon enough.

On Mon, Jun 12, 2023 at 8:53 PM Gareth Bowen @.***> wrote:

Hi @AbeebProPlus https://github.com/AbeebProPlus ! Thanks for reaching out. @isis-meng https://github.com/isis-meng has already started working in the above PR - how are you getting on with this issue?

— Reply to this email directly, view it on GitHub https://github.com/medic/cht-core/issues/8189#issuecomment-1587985771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQMNWN6ABH53LGKEDTP7U6TXK5XSHANCNFSM6AAAAAAXDMNZBQ . You are receiving this because you were mentioned.Message ID: @.***>

garethbowen commented 1 year ago

No response on the PR review so removing from the milestone.

@AbeebProPlus If you felt like picking up where @isis-meng left off that'd be great!