search

medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
467 stars 217 forks source link

Remove or correct invalid setting from example configs #8617

Open 1yuv opened 1 year ago

1yuv commented 1 year ago

What feature do you want to improve? Remove or correct invalid setting from example configs. For example, we still have reminders setting on app_settings like below.

https://github.com/medic/cht-core/blob/fc18e309f69586c64b15b9b2f5cc1651199ed2cc/config/standard/app_settings.json#L254-L261

cht logs this as an invalid reminder. 

Reminder configuration invalid: {
  form: '',
  text_expression: '',
  cron: '',
  mute_after_form_for: '',
  message: ''
}

Describe the improvement you'd like We need to either write config correctly or remove it as other CHT deployments can copy these configs and use from there.

Describe alternatives you've considered

Is this documentation still correct ?

dianabarsan commented 1 year ago

I believe the documentation is correct.