search

medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
436 stars 204 forks source link

User facing "Edit user profile" does not enforce validation for email #8863

Open mrjones-plip opened 5 months ago

mrjones-plip commented 5 months ago

What feature do you want to improve? When I'm a CHW logged in and I go to the hamburger menu, click "User Settings" and then click "Edit user profile" I can enter any email address I want (eg literal string invalid).

As an admin editing the same user, I'm forced to enter a valid email address.

Describe the improvement you'd like We should make both user and admin edit forms enforce the same level of validation.

Describe alternatives you've considered NA

Additional context Here's a video showing the validation differences in CHT 4.5.1. (Sorry - I have dark reader enabled so CHT doesn't look as it normally does in a browser!)

https://github.com/medic/cht-core/assets/8253488/c17991b4-e811-4c2d-80fc-54856527b102

anmol-fzr commented 2 months ago

Hi, I Would like to work on this issue can you assign me this issue for contribution

latin-panda commented 2 months ago

Hi @anmol-fzr thanks so much! Please let us know if you have question!

mrjones-plip commented 2 months ago

That's great news - thanks @anmol-fzr ! As @latin-panda said, please let us know if you have any questions, either here on this ticket or over on the forums.

As well, check out our documentation on submitting code and our code workflow.

Finally, often new folks on a project will have the best insights into how we can improve our docs for first time contributors - let us know!