search

medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
439 stars 211 forks source link

Admin upgrade page incorrectly shows "Error triggering upgrade" even if upgrade was successful #9186

Open dianabarsan opened 3 months ago

dianabarsan commented 3 months ago

Describe the bug This only affects older versions of the CHT installing newer versions, and it's caused by a change in the api/deploy-info interface: https://github.com/medic/cht-core/issues/8790

To Reproduce Steps to reproduce the behavior:

  1. Install 4.2.4
  2. Upgrade to 4.6.0. Wait until upgrade is complete.
  3. Notice that the upgrade page says "Error triggering upgrade" but the version displayed is 4.6.0.

Expected behavior The upgrade was successful, so the admin page should not report that upgrade was not.

Environment

Additional context This only affects upgrades from versions lower than 4.6.0 to versions higher than 4.6.0

dianabarsan commented 3 months ago

I've discovered this after adding the upgrade e2e test from 4.2.4 to current, and pushed the first tag. For branches the test works correctly.