kapelo commented 1 month ago

Description

Code review checklist

[ ] Readable: Concise, well named, follows the style guide, documented if necessary.
[ ] Documented: Configuration and user documentation on cht-docs
[ ] Tested: Unit and/or e2e where appropriate
[ ] Internationalised: All user facing text
[ ] Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

If Build CI hasn't passed, these may 404:

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

kapelo commented 1 month ago

Hi @Benmuiruri, two tests seem to be failing in your branch for mobile and doesn't fail on master. Can you take a look at this? cc: @latin-panda

Benmuiruri commented 1 month ago

@kapelo The error was because of the navigation change we have introduced.

L134 No longer works, when you try to navigate to Reports when the training card is open, it shows the "Leave training".

Let me use some of the logic from your PR to fix the updated behavior.

(PS - you might get some conflicts since I will be fixing the same file)