garethbowen commented 3 weeks ago

Description

8806

8402

Code review checklist

[ ] Readable: Concise, well named, follows the style guide, documented if necessary.
[ ] Documented: Configuration and user documentation on cht-docs
[ ] Tested: Unit and/or e2e where appropriate
[ ] Internationalised: All user facing text
[ ] Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

garethbowen commented 3 weeks ago

@1yuv Would you mind reviewing this? There are two regressions commented in the PR but I don't think anyone's going to notice. If you could run some of your configs through this update to confirm that would be ideal!

1yuv commented 3 weeks ago

I tested this with few configurations and I can combine multiple validations easily and is working perfectly.

1yuv commented 2 weeks ago

There's an #9604 I've filed that was discovered while testing this, but is not caused by this change.

medic / cht-core