medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
469 stars 217 forks source link

chore(n/a): e2e sync takes a long time because of unnecessary waits #9637

Closed dianabarsan closed 12 hours ago

dianabarsan commented 1 week ago

Description

This started off as a bug fix and then exploded. I branched of the bug fix and keeping this open to continue later, in a e2e focused PR.

Code review checklist

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

dianabarsan commented 1 week ago

Hi @latin-panda and @kapelo . I have this small PR that fixes a bug in the tasks component. I'd appreciate a review and QA assist.

For the QA assist, you will probably need to use a low performance device or tune your browser CPU performance throttling way up. I set it to 20x slowdown to consistently replicate the issue.

Appreciate it!

dianabarsan commented 1 week ago

Ok, it seems like one e2e test is consistently failing. I'll re-request the reviews when I've fixed it.

dianabarsan commented 12 hours ago

Closing in favor of https://github.com/medic/cht-core/pull/9659