medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
469 stars 217 forks source link

fix(#9612): hide last submitted task from task list #9650

Closed dianabarsan closed 4 days ago

dianabarsan commented 1 week ago

Description

Due to a recent debounce in setting contacts as dirty, we ended up waiting for two debounce delays when reload tasks: one from rules engine and one from tasks component itself. We previously had only one debounce, so this issue was less visible, but still existed.

As a fix:

9612

Code review checklist

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

dianabarsan commented 1 week ago

Hi @latin-panda and @kapelo

The last PR i tagged you on went sort of crazy in the direction of changing how we process sync in e2e tests. There are some good directions there, which I'm going to follow in a new PR, but at the same time I wanted to get this fix out sonner.

So, please, have a look and give me your feedback. Appreciate it!

latin-panda commented 4 days ago
Video: Reproducing issue in `master` https://github.com/user-attachments/assets/ed787149-b7e8-4e59-aaf1-41248ac9ecc9
Video: Fixed in branch "9612-dont-debouce-twice"; tasks seem to work fine as usual https://github.com/user-attachments/assets/c51527b9-48d9-4f1f-bdda-12fc1090a1a7

A task that creates another task or a task that is not resolved, both are updating the list fine

dianabarsan commented 4 days ago

Thanks @latin-panda . Why rebase? You mean cherry pick into 4.15.x ?

latin-panda commented 4 days ago

Ah no, I saw the branch was behind. I thought it had conflicts, but on second look now it doesn't have conflicts