medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
469 stars 217 forks source link

chore(#9585): teach Sentinel sign language #9658

Open dianabarsan opened 2 days ago

dianabarsan commented 2 days ago

Description

No longer start and stop sentinel to stop/start transitions and run scheduled tasks. Instead make it listen to two kill signals. Kill the test process if API is down in the before hook. This way we might get logs when the process ends up hanging.

9585

Code review checklist

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

dianabarsan commented 4 hours ago

hey @garethbowen . Wanna do a PR review for a change?

I've added signals to sentinel so we don't need to stop and start it. It doesn't entirely stabilize the k3d suites, because it doesn't address moments when API is not starting, but for that I've added one attempt to at least stop the process from hanging and instead quit early and hopefully we'll get more info from logs.

Appreciate your time and your ideas :)

dianabarsan commented 4 hours ago

Also fat fingered @latin-panda . Sorry for the noise!