medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
469 stars 217 forks source link

Update e2e sync to better handle reload modal #9660

Open dianabarsan opened 1 day ago

dianabarsan commented 1 day ago

Describe the issue When we sync, and an update comes, the update modal can appear before we see the sync status update to successful, and it will close the sidebar menu when it shows up. Right now, we wait for 5 seconds before we retry the syncing again.

Describe the improvement you'd like Improve the sync function so it handles rogue upgrade modals.

Describe alternatives you've considered Update webapp code so the modal only shows up after the sidebar menu has been closed through user action.

dianabarsan commented 9 hours ago

Comparison of test duration:

Test ~Master Proposed
ci-webdriver-default-mobile-all 7m30s 7m30s
ci-webdriver-default-core 14m 13m28s
ci-webdriver-default-data 16m30s 14m
ci-webdriver-default-enketo 14m30s 14m30s
ci-webdriver-default-lowLevel 11m23s 11m30s
ci-webdriver-default-workflows 28m 22m30s