search

medic / cht-gateway

Android SMS gateway app for CHT Applications
GNU Affero General Public License v3.0
84 stars 41 forks source link

URI encode basic auth passwords #143

Closed alxndrsn closed 5 years ago

alxndrsn commented 5 years ago

Closes #141

alxndrsn commented 5 years ago

Updated to use Uri.encode() instead of custom function. Uri and Uri.Builder do not seem to support differentiating the username and password from the rest of authority. A more complex fix would be to store username, password, scheme and the rest of the URL as four separate parts, but this would require deeper changes to the generic settings UI and a migration from the current settings storage format to a new alternative. Happy to look into it if we want to go this way.