search

medic / cht-infrastructure

Documentation and scripts needed to host the community health toolkit.
https://docs.communityhealthtoolkit.org/
Apache License 2.0
5 stars 2 forks source link

use curl to get docker compose file, exclude IDE files #12

Closed mrjones-plip closed 3 years ago

mrjones-plip commented 3 years ago

With the changes made in #10, we can't just run a cp to get the docker-compose.yml file - we need to fetch it from cht-core repo on GH. This PR fixes that.

It also excludes JetBrains IDE files in the .gitignore file

mrjones-plip commented 3 years ago

@henokgetachew - since you grabbed #10 - I figure it makes sense for you to grab this one too ;)

No rush!

nomulex commented 3 years ago

Just noted that this PR introduced a small issue with the prepare.sh file. The docker-compose file downloaded at this step from here, does not have the same docker volume structure as expected by the prepar.sh file here and in the read me here. We either need to put that disclaimer or we need to update the docker-compose file in cht-core to use the host volume as opposed to the docker volume.

Current volumes config.

volumes:
      - medic-data:/srv

Expected volumes config

volumes:
      - /srv:/srv
mrjones-plip commented 3 years ago

@nomulex - Oh no! I'm sorry about any regressions this PR caused. Thanks very much for the detailed comment clearly explaining the issue.

The original docker-compose.yml in this repo also had - medic-data:/srv back when we used to copy it to the right location (vs the new curl process). As far as I'm concerned SRE owns the main docker-compose.yml file and can make any changes needed to support Self-Hosted and AWS deployments. This is why we're using a different compose file for the developer effort we just released so there's no conflicts. It sounds like the fix in this case is to go to the /srv:/srv based declroration? Up to y'all!

That all said, unifying our docker-compose.yml files I think is a good thing to uncover these types of issues \o/