search

medic / cht-user-management

GNU Affero General Public License v3.0
3 stars 1 forks source link

Remove certificate-arn reference from deploy #123

Closed nydr closed 6 months ago

nydr commented 6 months ago

See https://github.com/medic/cht-user-management/pull/112#discussion_r1539531711 and https://github.com/medic/medic-infrastructure/issues/864 for more details

mrjones-plip commented 6 months ago

@nydr - there's some more instances of that 2023-wildcard-app certificate-arn out there, we're removing those because we want the charts to fall back to the default one, yeah? Should we chase these down and remove them too?

Hareet commented 6 months ago

@nydr - there's some more instances of that 2023-wildcard-app certificate-arn out there, we're removing those because we want the charts to fall back to the default one, yeah? Should we chase these down and remove them too?

Those were changed directly on k8s. Bad practice :(

We don't have a build server and helm isn't our main source of truth, so I hot-fixed :(

kennsippell commented 6 months ago

Deployed this in prod, working great