search

medic / cht-user-management

GNU Affero General Public License v3.0
3 stars 1 forks source link

disable and hide csv import button when request in flight #142

Closed freddieptf closed 1 month ago

freddieptf commented 2 months ago

Fixes #136 Fixes #63

kennsippell commented 2 months ago

The performance tweaks in this PR are spot-on.

For generation times, measured the change to enable cache: true in LiquidJS and it brought down time-to-generate by 80% (2.5s down to 0.5s). For response size, it brought responses sizes down 97% (from 3.5MB to ~125kb).

freddieptf commented 1 month ago

I just did a quick test and I think the buttons in the rows aren't working - try clicking "upload", "trash can", or "refresh" on any row in the table and nothing happens.

oh i missed that, i think it's a combination of how swaps are done on the table and https://github.com/bigskysoftware/htmx/pull/2247. I've updated the libraries and added support for individual row updates.

Edit: Looking into the swap errors now

freddieptf commented 1 month ago

@kennsippell I've made some changes to the events api and the updates should appear "faster" now. This should fix https://github.com/medic/cht-user-management/issues/63 as well