Closed paulpascal closed 3 months ago
Thanks @mrjones-plip for this great review, I will be going through them one by one and get back to you. About the publishing, I was also thinking, should it be possible to do it the same way we did for the current version (using publish script). Maybe it will need some updates on the current docker stuff I did? (Forgive if I'm sinning here 🥲 I am not a 😅pro on docker)
cc: @kennsippell
Thanks @kennsippell , great review. Really appreciate. Will be making the right adjustment
Testing today:
Cht command output:
output with all the new lines is extremely verbose. I think we can just output the raw data. It'd also be nice to output the actual command being executed.'json_docs
and upload-docs.*.json
into .gitignore since this is created when worker thread is run in active directory.adding new job to MOVE_CONTACT_QUEUE with [object Object]
Hi, @mrjones-plip it took a bit but finally got all the docker feedback addressed 🥲. Would you like to check it back when ever you have time?
@kennsippell, i have fixed the delay stuff as well.
Thanks
Thanks @mrjones-plip and @kennsippell for your great reviews 🔥.
Really appreciate that, will go through it thoroughly.
docker logs cht-user-management-cht-user-management-1 Error: connect ECONNREFUSED 192.168.16.2:6378 at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1606:16) { errno: -111, code: 'ECONNREFUSED', syscall: 'connect', address: '192.168.16.2', port: 6378 }
does this work for you?
Yes @mrjones-plip, it works for me, we can please have a little sync on that if its okay with you.
... I still was unable to log in, so please be sure and test this with a clean set up to ensure there's no regressions!
Thanks @mrjones-plip , I will make sure to have that working.
Closes: #12
This PR introduces a cloud-based execution of the
move-contact
feature, enhancing user experience by replacing the previouscht-conf
command-line approach.To achieve this, we've implemented bullmq, a powerful and flexible queue system built on Redis.
Here's a breakdown of the process:
Upon initiating a contact move, essential details such as
contact_id
,parent_id
,instanceUrl
, and the currentsessionToken
(encrypted) are compiled and submitted as a job to theMOVE_CONTACT_QUEUE
.A dedicated worker monitors this queue, processing incoming jobs:
cht-conf
command via achild_process
, utilizing all pertinent job data, including the decryptedsessionToken
.Upon successful execution, the job is marked as completed. In case of any failures, the job is flagged accordingly. Users can conveniently track job statuses directly from the user management tool's dashboard.