medic / cht-user-management

GNU Affero General Public License v3.0

3 stars 1 forks source link

Improvements to retry logic #58

Closed kennsippell closed 4 months ago

kennsippell commented 5 months ago

17

Updates so all axios requests are retried under specific conditions (500s, timeouts, etc)
Special considerations for retrying passwords (400) and update-conflicts (409s)
Unit tests capturing some retry scenarios which were called out as important in #17
Unit tests confirm the harmonious retry behavior of upload-manager and axios-retry
Simple test server to setup and try retry scenarios

kennsippell commented 4 months ago

Thanks for the review @freddieptf. Ready for 2nd round.

kennsippell commented 4 months ago

@freddieptf Great feedback and I will address it. This is the base branch for #56. @jonathanbataire is demoing to Uganda and needs that today so I'm merging. This PR has been out for 2 weeks, so tons of time to give feedback. I will address the axiosInstance concept in https://github.com/medic/cht-user-management/pull/75.