search

medic / cht-user-management

GNU Affero General Public License v3.0
3 stars 1 forks source link

add all hierarchy props to credential csv #83

Closed freddieptf closed 4 months ago

freddieptf commented 4 months ago

Actually fix https://github.com/medic/cht-user-management/issues/21

kennsippell commented 4 months ago

Particularly since you're adding constraints on functions like place.setPropertiesFromFormData where that function is now expected to always set the hierarchyProperties even for empty values... how can somebody working in that function know that this behavior is expected and not break this? It woud be great to see some tests for this.

kennsippell commented 4 months ago

@freddieptf Reminder to npm version patch for changes like this before merge