Closed mrjones-plip closed 6 months ago
So sorry for the delayed review here! :sweat: I plan to get to this today or tomorrow at the latest.
Nice! Tested out the fake setup and couch2pg data is getting pulled successfully.
One additional thing I did notice is that the
apply/revert-dev-patches
scripts are giving an error since they are trying to patch an old postgres config file. I think it should be sufficient to just delete thedevelopment/patches/apply/exporters.postgres.config.scrape_config.yml.patch
file (and the opposite one in therevert
directory. Those patches were just setting thescrape_interval
to a lower value. Now it looks like we are just inheriting the defaultscrape_interval
from theprometheus.yml
so there is no need to patch anything related to postgres....
Ah - thank you!! I saw errors earlier on when applying the patches and should have remembered to update this. fixed in 05266d1
Also - kudos on building an easy to maintain patch system - that was easy peasy!
:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Turns out that couch2pg doesn't need extra config to know what CHT instance it's gathering stats from. With this in mind we can both simplify the config as well support multi-couch2pg instances writing the same database.
This PR:
sql_instances.yml
postgres
->fake-postgres
). On the off chance you're running couch2pg in the same docker network you have twopostgres
service and, just like in highlander, there can be only one!PROMETHEUS_BIND
andPROMETHEUS_PORT
. This should be backwards compatible as it defaults to binding to127.0.0.1
. But with these.env
values below, you can easily run a debug setup by exposing all critical services on your bare-metal host. If it your host was IP192.168.68.26
, then you could do this:See also
For test steps, see main ticket.
per #107