medic / cht-watchdog

Configuration for deploying a monitoring/alerting stack for CHT
GNU Affero General Public License v3.0
4 stars 7 forks source link

feat(couch-backlog): multi-couch2pg isntances on 1 db, update fake-cht, add prometheus env vars #108

Closed mrjones-plip closed 6 months ago

mrjones-plip commented 6 months ago

Turns out that couch2pg doesn't need extra config to know what CHT instance it's gathering stats from. With this in mind we can both simplify the config as well support multi-couch2pg instances writing the same database.

This PR:

See also

For test steps, see main ticket.

per #107

jkuester commented 6 months ago

So sorry for the delayed review here! :sweat: I plan to get to this today or tomorrow at the latest.

mrjones-plip commented 6 months ago

Nice! Tested out the fake setup and couch2pg data is getting pulled successfully.

One additional thing I did notice is that the apply/revert-dev-patches scripts are giving an error since they are trying to patch an old postgres config file. I think it should be sufficient to just delete the development/patches/apply/exporters.postgres.config.scrape_config.yml.patch file (and the opposite one in the revert directory. Those patches were just setting the scrape_interval to a lower value. Now it looks like we are just inheriting the default scrape_interval from the prometheus.yml so there is no need to patch anything related to postgres....

Ah - thank you!! I saw errors earlier on when applying the patches and should have remembered to update this. fixed in 05266d1

Also - kudos on building an easy to maintain patch system - that was easy peasy!

medic-ci commented 6 months ago

:tada: This PR is included in version 1.14.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: