Run service in docker and connect over network in e2e tests

medic / couchdb-migration

0 stars 0 forks source link

Run service in docker and connect over network in e2e tests #2

Closed dianabarsan closed 1 year ago

dianabarsan commented 1 year ago

run service in docker (only)
add shard-move-instructions command
update couch service names to be URL parse-able and correct fqdn-s

dianabarsan commented 1 year ago

Hey @garethbowen Mind a quick look? I'm unsure about the delivery of this. It needs to run in a docker-container, and be in the same network in order to access the cluster http port (5986), unless we want to instruct people to expose that port temporarily to the host on the main node. I know you mentioned publishing a beta to npm. Unsure how to get from npm package to docker container.

garethbowen commented 1 year ago

Looks great. The only feedback I have is about installation. Clearly npm isn't right, but what about our ECR?

dianabarsan commented 1 year ago

but what about our ECR?

That's what I was thinking, and updated the documentation PR with that. Ideally we'd publish to ECR and update the docker-compose file in the main branch to download the latest tag or something like that.