search

medic / medic-os

A space-efficient Linux-based operating system, designed specifically to run Medic's mHealth platform. This is the build system and source code; Docker images will be available on Medic's website.
https://medic.org
GNU Affero General Public License v3.0
10 stars 6 forks source link

Redundant options in `adduser` call #17

Closed alxndrsn closed 6 years ago

alxndrsn commented 7 years ago

At https://github.com/medic/medic-os/blob/master/platform/packages/medic-rdbms/scripts/medic-rdbms/install#L89-L90, adduser is called with both -H and -h flags. These appear to be contradictory.

ghost commented 6 years ago

This is now in the initrd boot/include/utility file, and has been refactored.

The Busybox version of adduser is a little weird (e.g. -H -h /var/empty means "set $HOME to /var/empty but don't create it`), but all of this should be skipped now in the Dockerized Ubuntu-based builds. Closing; the Busybox code shouldn't be hit in production in 3.0+, and then we'll remove it.