search

medic / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
3 stars 3 forks source link

Rebase to xlsform #3

Closed alxndrsn closed 7 years ago

alxndrsn commented 7 years ago

This isn't actually a pull request, it's a replacement request – please don't hit the Merge button!

I've rebased Medic-specific adaptations of pyxform onto the master branch of upstream. A comparison can be seen here: https://github.com/XLSForm/pyxform/compare/master...alxndrsn:rebase-to-xlsform?expand=1

This will require an update to medic-configurer, but I'll see if I can push out the important bits in advance.

Ref https://github.com/medic/medic-webapp/issues/3756

abbyad commented 7 years ago

Some SMS compatibility bits may have been left out. For instance, the default values from https://github.com/medic/pyxform/pull/3/commits/e635bf4d2dc72b27231862928cadb3a9cfcb9fab are missing in the PR

abbyad commented 7 years ago

Nevermind! I see those now. A comparison of XForms after running on the Standard config will help identify any problems, but from the changes it looks good to me!

alxndrsn commented 7 years ago

We're now using branch at https://github.com/medic/pyxform/tree/medic-conf-1.5