search

medic / pyxform

A Python package to create XForms for ODK Collect.
BSD 2-Clause "Simplified" License
3 stars 3 forks source link

4682 remove blanks #4

Closed vimemo closed 6 years ago

vimemo commented 6 years ago

#4682 Removes text nodes with empty values:

-     <text id="/data/district_hospital/meta/created_by_place_uuid:label">
-          <value></value>
-      </text>

and also the label from groups with no_label values:

     <group appearance="field-list" ref="/data/district_hospital">
-      <label ref="jr:itext('/data/district_hospital:label')"/>
vimemo commented 6 years ago

@abbyad, please review. you can try this update by installing locally:

pip uninstall pyxform-medic
pip install git+https://github.com/medic/pyxform.git@4682-remove-blanks#egg=pyxform-medic
medic-conf --local convert-contact-forms
medic-conf --local upload-contact-forms

These are osx instructions. medic-conf/README has docs for installing in different os.

abbyad commented 6 years ago

Happy to do the acceptance testing on the issue, but will bring in @dianabarsan to do the code review.