medic / translation-checker

Check translations from .properties files with Mustache placeholders markup or messageformat syntax.
https://www.npmjs.com/package/@medic/translation-checker
GNU Affero General Public License v3.0
2 stars 0 forks source link

Add support for some non-ISO-639-1 languages we support #2

Open ngaruko opened 3 years ago

ngaruko commented 3 years ago

ATM we are using this iso-639-1 library to check for language codes. Recently, we have added a few languages that are not in that standards: ceb, hil and probably tl, for ICM Philippines. So, when one runs the upload-custom-languages command in medic-conf CLI, an error is thrown image I wonder if there is no package for ISO-639-2. Maybe iso-639-2-english - that way, we will have covered quite a good range of languages, just in case.

mrsarm commented 3 years ago

@ngaruko The primary problem here is that the message is shown with ERROR verbosity instead of WARN in medic-conf, making unclear for the user at first sight whether the process was aborted and the language was uploaded or not, which is not the case: the language is uploaded and the process not aborted.

What we need to do is: