medic / translation-checker

Check translations from .properties files with Mustache placeholders markup or messageformat syntax.
https://www.npmjs.com/package/@medic/translation-checker
GNU Affero General Public License v3.0
2 stars 0 forks source link

Add ignore rules to GH Actions #5

Closed mrsarm closed 3 years ago

mrsarm commented 3 years ago

Add ignore rules when only README files are edited in a PR.

mrsarm commented 3 years ago

@mrjones-plip as we talked yesterday I was experimenting in this PR the possibility of remove the duplicated jobs (https://github.com/medic/cht-core/pull/7321) but is not possible, so at least I want to add this small fix to skip builds when only README files are changed.

mrsarm commented 3 years ago

Should there be one or none here? Not sure if this catching CI mid change with the code. I kinda expected there to be none...

It's OK this PR to have jobs because it has changes in the .github/workflows/ci.yml file that isn't in the ignore list.

Even if you push later in the same PR changes only to the README file the CI jobs will be triggered because the full list of changes in the branch still have changes outside the README (although it shouldn't work like that IMHO).