Extra containers in Upgrade request (cht-nginx, cht-couchdb)

medic / upgrade-service-kubernetes

Upgrade service for k8s

0 stars 0 forks source link

Extra containers in Upgrade request (cht-nginx, cht-couchdb) #10

Closed Hareet closed 2 years ago

Hareet commented 2 years ago

The upgrade service kubernetes receives a request which contains containers that are not present in medic-hosted environments. I just wanted to make sure this scenario was covered.

Two things that came to mind:

We had initially decided to handle CouchDB upgrades in clustered environments at a later release for hosted projects. We could mix that in with a later upgrade-service-kubernetes release.
We won't run cht-nginx in hosted, so the upgrade service container should skip over any containers not already present. We haven't solved how to add new services seamlessly across deployment scenarios (later release).

@henokgetachew @dianabarsan Thoughts?

henokgetachew commented 2 years ago

The upgrade service kubernetes has been made future proof in this sense. There is a test here to make sure that's the case.

We won't run cht-nginx in hosted, so the upgrade service container should skip over any containers not already present. We haven't solved how to add new services seamlessly across deployment scenarios (later release).

That's already the case. So I'm closing this ticket as taken care of.

henokgetachew commented 2 years ago

I was speaking to extra things in the JSON payload - that has been handled. However, I wasn't referring to extra stuff inside the containers property within the payload. Right now, the upgrade service responds with error if you specify a non-existent container within the containers property. Reopening for further discussion.

henokgetachew commented 2 years ago

The idea right now is to just ignore containers that don't exist in the namespace.

henokgetachew commented 2 years ago

This has been taken care of. Tests also passing right now.