search

medienbaecker / kirby-link-field

29 stars 2 forks source link

required has no effect #15

Open dgsiegel opened 5 years ago

dgsiegel commented 5 years ago

required: true does not seem to have an effect on this field. According to the Kirby docs the field has to be filled in correctly to be saved. But it behaves like a normal text field with no validation at all. Would be nice if it would behave like the original Url field.

fields:
  button:
    label:  Button
    type:   link
    required: true
medienbaecker commented 5 years ago

"filled in": easily possible "filled in correctly": difficult

Ideally the field would use the validation of the url, page, email, file or phone field, depending on the type that was selected.

dgsiegel commented 5 years ago

I don't think easy or hard should be the right criteria for this issue :) But I'd expect to either have all the Kirby settings working correctly or to have it documented somewhere, that they are deliberately ignored.

medienbaecker commented 5 years ago

FYI: this issue depends on this core issue: https://github.com/getkirby/ideas/issues/234