search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Randomize Unit Tests #108

Closed razo7 closed 10 months ago

razo7 commented 11 months ago
  1. Randomize unit tests
  2. Ensure unit tests are independent for randomly running the specs
openshift-ci[bot] commented 11 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 11 months ago

/test ?

openshift-ci[bot] commented 11 months ago

@mshitrit: The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/108#issuecomment-1826721332): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mshitrit commented 11 months ago

/test 4.12-openshift-e2e

slintes commented 10 months ago

lgtm

but did we actually agree that we want to have this? I remember some discussion in chat... 🤔

razo7 commented 10 months ago

but did we actually agree that we want to have this? I remember some discussion in chat... 🤔

IIRC we agreed not to do a repetition, but the concept of randomization was accepted.

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 10 months ago

/retest

razo7 commented 10 months ago

/retest