search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Shorten Timeouts for E2e Tests #113

Closed razo7 closed 10 months ago

razo7 commented 10 months ago
openshift-ci[bot] commented 10 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

slintes commented 10 months ago

because of

won't be needed after ...

this should not be merged before the other PR, otherwise we miss a test...

/hold

clobrano commented 10 months ago

checkFarLogs is already removed in #106

razo7 commented 10 months ago

this should not be merged before the other PR, otherwise we miss a test...

It is a step in a test, and not a full test but I agree that it is better to wait. However, having the checkFarLogs step will fail the e2e due to the #112 change since checkFarLogs checks the logs of the first FAR running pod (e.g., see failing e2e tests at #107), when we have now two running pods at any time.

checkFarLogs is already removed in https://github.com/medik8s/fence-agents-remediation/pull/106

Correct, so either we merge this PR or the other one, otherwise every e2e test could fail due to the #112 change and we can't merge the remaining PRs. I lean to merge this small PR first rather than the other large one.

clobrano commented 10 months ago

I lean to merge this small PR first rather than the other large one.

Please do not. It's been already a bit tricky to rebase #106 onto #108, I'd rather get the first in before moving on with further changes to e2e tests.

razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 10 months ago

/test 4.14-openshift-e2e

razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 10 months ago

/test 4.15-openshift-e2e

razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

mshitrit commented 10 months ago

/lgtm

razo7 commented 10 months ago

/unhold /retest