Closed razo7 closed 10 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: razo7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
because of
won't be needed after ...
this should not be merged before the other PR, otherwise we miss a test...
/hold
checkFarLogs
is already removed in #106
this should not be merged before the other PR, otherwise we miss a test...
It is a step in a test, and not a full test but I agree that it is better to wait.
However, having the checkFarLogs
step will fail the e2e due to the #112 change since checkFarLogs
checks the logs of the first FAR running pod (e.g., see failing e2e tests at #107), when we have now two running pods at any time.
checkFarLogs is already removed in https://github.com/medik8s/fence-agents-remediation/pull/106
Correct, so either we merge this PR or the other one, otherwise every e2e test could fail due to the #112 change and we can't merge the remaining PRs. I lean to merge this small PR first rather than the other large one.
I lean to merge this small PR first rather than the other large one.
Please do not. It's been already a bit tricky to rebase #106 onto #108, I'd rather get the first in before moving on with further changes to e2e tests.
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
/test 4.14-openshift-e2e
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
/lgtm
/unhold /retest