Closed razo7 closed 10 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: razo7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
/test 4.14-openshift-e2e /test 4.15-openshift-e2e
/lgtm
In any case I suggest doing couple a simple check (in case you haven't done already) before merging that works as expected.
something like:
PREVIOUS_VERSION=0.1.0 VERSION=0.2.0 make bundle-update
VERSION=0.2.0 make bundle-update
- should be rejected
make bundle-update
/retest
Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version and ensure that the old version isn't deleted from the index.
docs.engineering.redhat.com/display/CFC/Best_Practices#Best_Practices-SkipRange
Similar to https://github.com/medik8s/self-node-remediation/pull/167, https://github.com/medik8s/node-maintenance-operator/pull/108 and related to ECOPROJECT-1771