Set Replace Annotation - Githubissues

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.

https://www.medik8s.io/

Apache License 2.0

9 stars 8 forks source link

Set Replace Annotation #115

Closed razo7 closed 10 months ago

razo7 commented 10 months ago

Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version and ensure that the old version isn't deleted from the index.

docs.engineering.redhat.com/display/CFC/Best_Practices#Best_Practices-SkipRange

openshift-ci[bot] commented 10 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 10 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

mshitrit commented 10 months ago

/lgtm

In any case I suggest doing couple a simple check (in case you haven't done already) before merging that works as expected. something like: PREVIOUS_VERSION=0.1.0 VERSION=0.2.0 make bundle-update VERSION=0.2.0 make bundle-update - should be rejected make bundle-update

razo7 commented 10 months ago

/retest