medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Initialize Event Recorder for executer #120

Closed razo7 closed 8 months ago

razo7 commented 8 months ago

Fix ECOPROJECT-1816

openshift-ci[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 8 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

mshitrit commented 8 months ago

I think a UT capturing an event would be nice

razo7 commented 8 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 8 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

mshitrit commented 8 months ago

/lgtm

razo7 commented 8 months ago

/test 4.13-openshift-e2e