Build container using x.y.z golang version and updating Golang version

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.

https://www.medik8s.io/

Apache License 2.0

9 stars 8 forks source link

Build container using x.y.z golang version and updating Golang version #133

Closed razo7 closed 5 months ago

razo7 commented 6 months ago

Why we need this PR

Simplify how the Dockerfile fetches the Golang version for building the binary.

Changes made

Fetch the Golang version from the go directive in go.mod, and download it using the repos of the base image (CentOS stream 8) instead of using the official website to download and extract the newer Golang version
Upgrade Golang 1.20-> 1.21.7 and use the patch version in go.mod
Modify ci-operator.yaml file for Golang builder in OCP CI.

Which issue(s) this PR fixes

Follow up to #132, and should not be merged beforehand.

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

slintes commented 6 months ago

/test 4.15-test

razo7 commented 6 months ago

/test 4.15-test

razo7 commented 6 months ago

/test 4.15-test

razo7 commented 6 months ago

/test 4.15-test

razo7 commented 6 months ago

/test 4.15-openshift-e2e

razo7 commented 5 months ago

There is a tradeoff for using a patch version (here and eventually aligning it in other places) for Golang builder, and the pros won't overcome the cons. It might be more relevant in the future, but not for now.