Add support to multiple templates with the same kind

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.

https://www.medik8s.io/

Apache License 2.0

9 stars 8 forks source link

Add support to multiple templates with the same kind #135

Closed mshitrit closed 7 months ago

mshitrit commented 7 months ago

Why we need this PR

This PR will enable the user to select several FAR Templates (of the same kind) when using NHC escalating remediation. In a nutshell Far can be used several times as a remediator each time with a different fence agent. This feature is dependent on the changes in NHC as well (which will be available from NHC 0.8.0).

Changes made

Added a "Defaulting" (Mutating) Webhook to Far's Template which automaticlly adds to the template the "Support Same Kind" annotation which NHC detects
Fetching node name from "Node Name" annotation in case it exist instead of always assuming that the Node's name is the CR's name
Upgraded common version in order to use both mentioned annotations from common

Which issue(s) this PR fixes

ECOPROJECT-1918

Test plan

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 7 months ago

/test 4.14-openshift-e2e

mshitrit commented 7 months ago

/test 4.14-openshift-e2e

mshitrit commented 7 months ago

/test 4.14-openshift-e2e

mshitrit commented 7 months ago

/test 4.14-openshift-e2e

razo7 commented 7 months ago

/test 4.14-openshift-e2e

I would recommend testing on 4.15. since it is the latest version we have in CI, and it was already released :) /test 4.15-openshift-e2e

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment