medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Manual workflow for tagged versions #136

Closed clobrano closed 7 months ago

clobrano commented 7 months ago

Why we need this PR

FAR CI uses the post-release workflow for building and pushing versioned bundle images, however, the workflow cannot guess the right PREVIOUS_VERSION (when it is necessary) and it would publish manifests with wrong value of the .spec.replaces field.

Changes made

Test plan

Tested locally with nektos/act

ECOPROJECT-1579

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

@clobrano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-openshift-e2e 1c4cd22b155e834caa5bce144cc89f21d2913970 link true /test 4.12-openshift-e2e
ci/prow/4.15-openshift-e2e 1c4cd22b155e834caa5bce144cc89f21d2913970 link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
clobrano commented 7 months ago

E2E tests do not test the changes of this PR. Can merge without them.