medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Build a file-based catalog #138

Closed clobrano closed 6 months ago

clobrano commented 6 months ago

Why we need this PR

Currently FAR Makefile creates a db-based catalog, which was deprecated

DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.

Changes made

This change create a file-based catalog

https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1947

Test plan

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 6 months ago

e2e tests won't test this change, so there is no need to run them

razo7 commented 6 months ago

/lgtm Left one nit though

razo7 commented 6 months ago

/lgtm

clobrano commented 6 months ago

/retest

clobrano commented 6 months ago

/approve

razo7 commented 6 months ago

All the tests are green and I think only the tide job hasn't been activated. Maybe we should restart the jobs with /retest

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,mshitrit,razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment