search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Update bundle image #139

Closed razo7 closed 4 months ago

razo7 commented 5 months ago

Why we need this PR

Introduce a new target, bundle-run-update, for testing an operator upgrade. It could be used as well for downgrading or reinstalling the operator (instead of running the bundle-cleanup and then bundle-run).

Run 'VERSION=SOME_VERSION' prior to running the bundle-run or bundle-run-update targets to modify the installed or replaced bundle CSV.

The new target will be used for testing operator upgrades in OCP CI - https://github.com/openshift/release/pull/50559

Changes made

Which issue(s) this PR fixes

ECOPROJECT-1082

Test plan

Similar to PR of NMO #120

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 5 months ago

Considering that it supposed to perform both upgrade and downgrade, would be bundle-run-replace be a clearer option?

razo7 commented 5 months ago

Considering that it supposed to perform both upgrade and downgrade, would be bundle-run-replace be a clearer option?

I don't have a strong preference here. bundle-run-update also seems fine as we update the CSV.

razo7 commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 4 months ago

/lgtm cancel

slintes commented 4 months ago

/lgtm

slintes commented 4 months ago

ping tide

openshift-ci[bot] commented 4 months ago

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-openshift-e2e 31ace8461d4ef5429010b421018e57a65c662295 link unknown /test 4.12-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slintes commented 4 months ago

/retest