medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Run bundle in test target to ensure bundle is up to date #140

Closed slintes closed 6 months ago

slintes commented 6 months ago

Why we need this PR

The current tests does not check if the bundle directory is up to date.

Changes made

Added bundle-reset target to test target.

Which issue(s) this PR fixes

n/a

Test plan

tested locally with a temporary change to an API field description

slintes commented 6 months ago

/test 4.15-test

slintes commented 6 months ago

/test 4.15-test

slintes commented 6 months ago

/test 4.15-test

razo7 commented 6 months ago

/lgtm

slintes commented 6 months ago

just to be sure, running one e2e test...

/test 4.15-openshift-e2e

slintes commented 6 months ago

e2e CI is broken atm...

slintes commented 6 months ago

/retest

slintes commented 6 months ago

/retest

slintes commented 6 months ago

trying to wake up tide...

/skip

slintes commented 6 months ago

/skip

slintes commented 6 months ago

/override ci/prow/4.12-test

openshift-ci[bot] commented 6 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.12-test

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/140#issuecomment-2052233454): >/override ci/prow/4.12-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slintes commented 6 months ago

/approve cancel

slintes commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment