Check stderr when running agent

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.

https://www.medik8s.io/

Apache License 2.0

9 stars 8 forks source link

Check stderr when running agent #142

Closed razo7 closed 4 months ago

razo7 commented 6 months ago

Why we need this PR

Considering a successful command execution when the return value is zero, no error, and stderr is empty as well.

Changes made

Include a check for stderr being empty when considering a successful agent execution.

Which issue(s) this PR fixes

Fixes (somehow) ECOPROJECT-1938

Test plan

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 4 months ago

@razo7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.17-ci-bundle-my-bundle	fb9cef93a8ccce9823c7ce0ec85af81224fbfebe	link	true	`/test 4.17-ci-bundle-my-bundle`
ci/prow/4.17-images	fb9cef93a8ccce9823c7ce0ec85af81224fbfebe	link	true	`/test 4.17-images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

slintes commented 4 months ago

/close

openshift-ci[bot] commented 4 months ago

@slintes: Closed this PR.

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/142#issuecomment-2199435539): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.