Remove redundant VoulmeAttachment from testing

razo7 commented 6 months ago

Why we need this PR

VoulmeAttachment is no longer removed from the resource deletion strategy, thus it is no longer needed for testing. Follow up to #102 .

Changes made

Remove VoulmeAttachment creation and deletion in unit-test.

Which issue(s) this PR fixes

Test plan

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

razo7 commented 6 months ago

/test ci/prow/4.16-openshift-e2e

openshift-ci[bot] commented 6 months ago

@razo7: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test 4.12-ci-bundle-my-bundle
/test 4.12-images
/test 4.12-openshift-e2e
/test 4.12-test
/test 4.13-ci-bundle-my-bundle
/test 4.13-images
/test 4.13-openshift-e2e
/test 4.13-test
/test 4.14-ci-bundle-my-bundle
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.14-test
/test 4.15-ci-bundle-my-bundle
/test 4.15-images
/test 4.15-openshift-e2e
/test 4.15-test
/test 4.16-ci-bundle-my-bundle
/test 4.16-images
/test 4.16-openshift-e2e
/test 4.16-test

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/144#issuecomment-2060993428): >/test ci/prow/4.16-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

razo7 commented 6 months ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

razo7 commented 6 months ago

/retest

razo7 commented 6 months ago

/retest

razo7 commented 6 months ago

/hold Waiting for #92 to be merged first

razo7 commented 6 months ago

/unhold

razo7 commented 6 months ago

tide job is not responding, so I am pushing old commit as a new one to retrigger tide (with the many other tests)...

razo7 commented 6 months ago

/retest

slintes commented 6 months ago

/lgtm

slintes commented 4 months ago

/retest

slintes commented 4 months ago

/retest

slintes commented 4 months ago

/hold

need to fix CI config for having e2e tests required

slintes commented 4 months ago

/hold cancel

slintes commented 4 months ago

/test 4.17-ci-bundle-my-bundle

razo7 commented 4 months ago

/retest

slintes commented 3 months ago

/retest

slintes commented 3 months ago

/test 4.13-openshift-e2e /test 4.15-openshift-e2e

medik8s / fence-agents-remediation