search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Fix release workflow job #146

Closed clobrano closed 3 months ago

clobrano commented 3 months ago

Why we need this PR

Currently, the "Create release with manifests" step in the release CI Job is wrongly conditioned under a specific value of github.ref_type ('tag'). This is a leftover of the recent rework and prevent the relece CI to publish the release manifest on GitHub.

Changes made

Remove the condition from "Create release with manifests" step

Which issue(s) this PR fixes

Test plan

This change can be tested only once it is merged, unfortunately.

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 3 months ago

This PR does not need e2e tests

/override "ci/prow/4.14-openshift-e2e"

openshift-ci[bot] commented 3 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.14-openshift-e2e

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/146#issuecomment-2126876619): >This PR does not need e2e tests > >/override "ci/prow/4.14-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
clobrano commented 3 months ago

/override "ci/prow/4.15-openshift-e2e"

openshift-ci[bot] commented 3 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.15-openshift-e2e

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/146#issuecomment-2126877116): >/override "ci/prow/4.15-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
clobrano commented 3 months ago

The first time it just aborted the test, which resulted in a failure

/override "ci/prow/4.15-openshift-e2e"

openshift-ci[bot] commented 3 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.15-openshift-e2e

In response to [this](https://github.com/medik8s/fence-agents-remediation/pull/146#issuecomment-2126880273): >The first time it just aborted the test, which resulted in a failure > > >/override "ci/prow/4.15-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.