search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Update Makefile #151

Closed clobrano closed 3 months ago

clobrano commented 3 months ago

Why we need this PR

The current Makefile needs update for

adding the mandatory annotation, I also noted an issue in CI which I decided to fix here, see the first change in the next section.

Changes made

Which issue(s) this PR fixes

Test plan

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 3 months ago

/test 4.16-openshift-e2e

clobrano commented 3 months ago

Dropping last commit, as it is already included in https://github.com/medik8s/fence-agents-remediation/pull/150

clobrano commented 3 months ago

superseded by #152