medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Add mandatory annotations for OKD bundle #152

Closed clobrano closed 1 month ago

clobrano commented 1 month ago

OKD community pipeline is verifying the presence of OCP annotation.

Moreover, I fixed a typo in the release template.

Why we need this PR

Changes made

Add OCP annotation to OKD bundle

Which issue(s) this PR fixes

Test plan

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 1 month ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 1 month ago

@clobrano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/4.13-openshift-e2e aaa780e link true /test 4.13-openshift-e2e

Full PR test history. Your PR dashboard.

Deployment not completed (maybe network issue)

NodeCADaemonProgressing: The daemon set node-ca is deploying node pods  Operator progressing (DeploymentNotCompleted::NodeCADaemonUnavailable): Progressing: The deployment has not completed
clobrano commented 1 month ago

/retest

clobrano commented 1 month ago

I made a mistake here. I was somehow using go > 1.20 locally and didn't notice, but since FAR has version 1.20, YQ needs to be <= 4.42.1, not 4.44.2

I will fix this in a next PR