Closed k-keiichi-rh closed 1 month ago
Hi @k-keiichi-rh. Thanks for your PR.
I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/retest
If the PR changes suit your needs and it is ready to be approved and reviewed, then please remove [WIP]
from the PR title as it adds a blocker label do-not-merge/work-in-progress
@k-keiichi-rh
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: k-keiichi-rh, razo7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
As far as I checked, I have no concerns for this patch. I appreciate it if you could review the patch. Thanks.
Looking at the logs it works as designed. Thank you @k-keiichi-rh for this improvement to the e2e test code. /lgtm
Why we need this PR
Refactoring for the duplicated code in e2e tests
Changes made
Extract the common test routine and remove the duplication