search

medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

Remove duplicated code in e2e tests #155

Closed k-keiichi-rh closed 1 month ago

k-keiichi-rh commented 2 months ago

Why we need this PR

Refactoring for the duplicated code in e2e tests

Changes made

Extract the common test routine and remove the duplication

openshift-ci[bot] commented 2 months ago

Hi @k-keiichi-rh. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
razo7 commented 2 months ago

/ok-to-test

razo7 commented 2 months ago

/retest

razo7 commented 1 month ago

If the PR changes suit your needs and it is ready to be approved and reviewed, then please remove [WIP] from the PR title as it adds a blocker label do-not-merge/work-in-progress @k-keiichi-rh

razo7 commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k-keiichi-rh, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k-keiichi-rh commented 1 month ago

As far as I checked, I have no concerns for this patch. I appreciate it if you could review the patch. Thanks.

razo7 commented 1 month ago

Looking at the logs it works as designed. Thank you @k-keiichi-rh for this improvement to the e2e test code. /lgtm