Update Tools and API Versions

[razo7]

Bump FAR to the latest tool and API versions (e.g. K8s, OCP, Controller-gen, Kustomize, and Operator-SDK).

In addition it also includes more stuff:

• Fix for writing/deleting the envtest target directory
• Fetching the machine client (for E2E) using OpenShift client-go

ECOPROJECT-1403

[razo7]

Golang must be v1.20 prior to merging this PR. /hold Wait for #57 to be merged

[razo7]

E2E test will fail as it needs https://github.com/openshift/release/pull/40248 to be merged, so Golang version on E2E will be updated

[razo7]

/retest

[mshitrit]

/lgtm /hold Giving others chance to review

[clobrano]

/lgtm

Giving a chance to get more feedbacks, feel free to unhold /hold

[razo7]

I hope #20 will be merged soon, and I prefer to wait for this PR to be merged. Since the current PR introduce huge bump (by time of versions, and not necessarily of FAR's functionality), thus I would prefer to wait for #20.

[razo7]

/retest

[razo7]

E2E PR was merged and this PR is ready for review

[razo7]

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test and in another PR I will update and fix deprecation warnings due to Kustomize v5 changes.

migrate all of them to the new format.

When you say new format are you referring to Kubebuilder go/v3 to g0/v4? I remembered that go/v4 was still as alpha, and looking again I see that it has already been stabilized ECOPROJECT-1315

[razo7]

there are also code changes, probably also worth their own PR?

I was thinking of doing another PR for them.

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test

But looking again on the changes, they are quite minor IMHO, and due to bumping the K8s and OCP APIs I was aware of an error with vet under vendor due to the old github.com/openshift/machine-api-operator package. Therefore, I would prefer to let the these code changes remain in this PR. I can update the PR's title if you still see a need for that. WDYT?

[slintes]

there are also code changes, probably also worth their own PR?

I was thinking of doing another PR for them.

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test

But looking again on the changes, they are quite minor IMHO, and due to bumping the K8s and OCP APIs I was aware of an error with vet under vendor due to the old github.com/openshift/machine-api-operator package. Therefore, I would prefer to let the these code changes remain in this PR. I can update the PR's title if you still see a need for that. WDYT?

ack, wfm

[razo7]

Updating to kustomize v5, and removing new deprecation warnings will be done in a follow up PR when we change the project layout to go/v4 - ECOPROJECT-1315

[razo7]

/unhold

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment