Add Status Conditions for FAR CR

razo7 commented 1 year ago

Adding three status conditions (Processing, FenceAgentActionSucceeded, and Succeeded) to help FAR in two ways:

Convey the status of processing the CR, if the fence agent action was succeeded (only once), and if the whole remediation was succeeded (node was tainted with FAR taint, fence agent action was succeeded, and the workloads have been deleted).
Limit the available sections in the reconcile based on the conditions, e.g., reboot and resource deletion will finish successfully only once.

Moreover, each status condition includes a reason and a message based on ProcessingChangeReason that changed the condition value. The PR also updates reconcile structure :

Fetch FAR CR, validate CR name, check NHC timeout annotation, and add finalizer. ProcessingChangeReason = RemediationStarted
Try to add FAR taint, build FA command and execute it (until it succeeds). ProcessingChangeReason = FenceAgentSucceeded
Try to delete workloads. ProcessingChangeReason = RemediationFinished

ECOPROJECT-1411 ECOPROJECT-1484

openshift-ci[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

razo7 commented 1 year ago

/test 4.13-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

mshitrit commented 1 year ago

/test 4.12-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e

razo7 commented 1 year ago

/test 4.13-openshift-e2e /test 4.14-openshift-e2e

razo7 commented 1 year ago

/retest

slintes commented 1 year ago

oh, CI missed to add the label

/lgtm

medik8s / fence-agents-remediation

Add Status Conditions for FAR CR #69