Closed clobrano closed 10 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Really a WIP :smiley:
Would it make more sense to merge this PR to a feature branch, job-custom-fa
, rather than the main
branch?
This PR, alone, is destructive to FAR.
Making more small PRs for "create a Job to execute fencing-agents on a node",
"handle Job's life cycle", and "stop Job in case of time out" to a feature branch and then merge to main
seems easier to review IMO.
Would it make more sense to merge this PR to a feature branch, job-custom-fa, rather than the main branch?
yes, it makes totally sense. Not sure I can change this PR, or I need to make a new one
Would it make more sense to merge this PR to a feature branch, job-custom-fa, rather than the main branch?
yes, it makes totally sense. Not sure I can change this PR, or I need to make a new one
I think you can change it, click on edit
at the beginning of the page..
I think you can change it, click on
edit
at the beginning of the page..
correct, and sorry for the noise of the other PRs :sweat:
Use Jobs to execute fencing agents