medik8s / fence-agents-remediation

Kubernetes Operator for providing high availability between nodes by automatically remediating them using well-known fence-agents.
https://www.medik8s.io/
Apache License 2.0
9 stars 8 forks source link

[WIP] Use Jobs to execute fencing agents #87

Closed clobrano closed 10 months ago

clobrano commented 11 months ago

Use Jobs to execute fencing agents

openshift-ci[bot] commented 11 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/fence-agents-remediation/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 11 months ago

Really a WIP :smiley:

razo7 commented 11 months ago

Would it make more sense to merge this PR to a feature branch, job-custom-fa, rather than the main branch? This PR, alone, is destructive to FAR. Making more small PRs for "create a Job to execute fencing-agents on a node", "handle Job's life cycle", and "stop Job in case of time out" to a feature branch and then merge to main seems easier to review IMO.

clobrano commented 11 months ago

Would it make more sense to merge this PR to a feature branch, job-custom-fa, rather than the main branch?

yes, it makes totally sense. Not sure I can change this PR, or I need to make a new one

razo7 commented 11 months ago

Would it make more sense to merge this PR to a feature branch, job-custom-fa, rather than the main branch?

yes, it makes totally sense. Not sure I can change this PR, or I need to make a new one

I think you can change it, click on edit at the beginning of the page..

clobrano commented 11 months ago

I think you can change it, click on edit at the beginning of the page..

correct, and sorry for the noise of the other PRs :sweat: