search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Add etcd quorum check for cp node remediation #272

Closed slintes closed 10 months ago

slintes commented 10 months ago

In order to better protect control plane nodes, add a etcd quorum guard check which can prevent cp node remediation

ECOPROJECT-1003

slintes commented 10 months ago

/test 4.14-openshift-e2e

razo7 commented 10 months ago

/lgtm

slintes commented 10 months ago

/override e2e-k8s

openshift-ci[bot] commented 10 months ago

@slintes: Overrode contexts on behalf of slintes: e2e-k8s

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/272#issuecomment-1864530616): >/override e2e-k8s Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 10 months ago

/hold cancel

2 reviews are good enough, are they? 😉