search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Fix for CP Nodes Remediation #275

Closed razo7 closed 9 months ago

razo7 commented 9 months ago

Allow CP nodes remediation when DisruptionsAllowed is greater equal than zero. When NHC is detecting an unhealthy node then the DisruptionsAllowed is decreased by one.

Consider 3 CP nodes cluster and when we check pdb guard after NHC CR was created then DisruptionsAllowed=0 (#healthy CP nodes 3->2 == 2 majority node). When it is below zero, then we can be positive that not only this unhealthy node (from the CR) is unhealthy

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 9 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 9 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

razo7 commented 9 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

openshift-ci[bot] commented 9 months ago

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.15-openshift-e2e 0e59e3ee3e77a79b29f18b3898b6871b683a48ce link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slintes commented 9 months ago

This won't work, closing in favor of #276

/close

openshift-ci[bot] commented 9 months ago

@slintes: Closed this PR.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/275#issuecomment-1877588689): >This won't work, closing in favor of #276 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.